island94.org

*oops* my use of code tags didn’t work, so ignore the ‘it should read’ bit.

This is a great bit of code. In trying to control the look of the filename, I noted that there’s a missing closing span tag on line 23 of upload_attachments.tpl.php, to close the class=file-name block. It should read:


$file_metadata = '

Many thanks for this.

Whoa, this is slick.

Any way this can be made to work with 5.x? Any pointers for me to backport it?

Thanks for this!

This is a great bit of code. But really didn`t make any difference. Thanks anyway

How could us alter this code to open the associated link in a new browser window?

Hi,

Thanks very much for this! It works fine in 5.x with the Zen theme. To get it to work, I madea few minor amendments.

1. Add the following to your template.php

function phptemplate_upload_attachments($files) {
return _phptemplate_callback('upload_attachments', array('files' => $files));
}


2. Place upload_attachments.tpl.php, shiny_upload.css, and the file-icons folder in the same directory level as template.php

3. In the function _shiny_upload_create_icon_path, I used path_to_subtheme

$iconpath = path_to_subtheme()
.'/file-icons/'. $theme .'/16x16/mimetypes/'. $iconname .'.png';


Hope this helps!

MB, the search function produces the same message for me, so you are not alone :( and I don’t know the solution. But someone maybe hears us…

This module doesn’t work with the Drupal Search function.

I used it in Drupal 6.X. However whenever the search results in more than two documents which match the keyword, I get a fatal error:

PHP Fatal error: Cannot redeclare shiny_upload_upload_attachments() (previously declared in /var/site_XXX/sites/all/themes/marinelli/shiny_upload/upload_attachments.tpl.php:14) in /var/site_XXX/sites/all/themes/marinelli/shiny_upload/upload_attachments.tpl.php on line 33, referer: http://www.XXX.com/

I like what the module does and it works on views, home page etc where the nodes are listed in some form of list, but I think the search functionality is very important and that is leading to multiple inclusion of the function. For example, as a test I made the following change in theme.inc:

function theme_render_template($template_file, $variables) {
extract($variables, EXTR_SKIP); // Extract the variables to a local namespace
ob_start(); // Start output buffering
include_once “./$template_file”; // Include the template file —> CHANGED include to include_once
$contents = ob_get_contents(); // Get the contents of the buffer
ob_end_clean(); // End buffering and discard
return $contents; // Return the contents
}

Then the search results started to work, but the views were returning only one single node.

Any fixes for the redeclaration issue?

wow, what a difference! thx a lot for this hack.

Although it’s a little bit bigger then the usual snippet; you could add it to the Drupal handbook on the Theme Snippets page (http://drupal.org/node/45471) ?

Thanks! These kind of small changes can make a use difference to the looks of a site.

Very Very Useful. Thanks a lot.

Thank you, this is a great improvement.

I do have one problem, however — my site won’t show the icons. My themes, however, are not in the sites/default/all/ folder, and I’m wonder if this might be my problem?

Thanks for this ! However it’s generating problems with the cron : it’s printing the

This ‘module’ gives problems when running cron.
I haven’t investigated further but i guess it has to do with the print shiny_upload_upload_attachments($files);
which is on top of the upload_attachments.tpl.php file.

I’ll investigate further and report back..

Crossposting..

See http://groups.drupal.org/node/13873#comment-59812 for my comment.
Grab the fix on http://krimson.be/en/shiny-upload-almost-converted-a-module

@island94: Are you interesting in commiting your code into a proper drupal project, PM me if you need help.

I have solved the problem:
you have to move the function declarations into one other file, good place is for example into one custom module. The upload_attachments.tpl.php only contains the print and drupal_add_css invocations.

In additional change for this code to work with Drupal 5, the l() function which reads:

$file_link = ”. l(shiny_upload_file_icon($file) . $text, $file_url, array(‘html’=>’true’)) . ”;

Should be changed to:

$file_link = ”. l(shiny_upload_file_icon($file) . $text, $file_url, array(), null, null, false, true) . ”;

I love it. Thanks.

If you have an issue with Search Module, you can move functions (as mentioned qrta) into template.php.

fYI if you are using “Garland” theme and have specified custom colors using the color picker you must physically delete the cached Garland theme at sites/default/files/color/garland-xxxxx

Then you must configure and save your theme to reset this cache. Note that garland “color picker” doesn’t work if your file method is Private.

If you are using private file method and Garland and have lots of files I do not suggest you attempt to use this file icon hack at all or you risk changing file paths for all your attachments.

I used the iTweak Upload (http://drupal.org/project/itweak_upload) module and it works great!